Andy Clark wrote:
>
> Petr Kuzel wrote:
> > - XMLAttributes.getName(int,QName)
>
> I added set/getName(int,QName) for convenience. I have no
> problem with removing them if we then add the appropriate
> set methods for the various parts of the qualified name.
I did not have nothing against convenience methods in the interface.
There is just overlook that getName() actually sets one.
Now I am not sure if the interface should contain convenience
methods (The only pros I can see it is that a direct implementation
may be faster than utility wrapper class. It similar to removed
entity refs convenience methods.).
[snip]
great!
[snip]
>
> > - I still miss definition of call order i.e. requirement for
> > proper nesting of startXXX() and endXXX() events so it would
> > be guaranteed that handler can use single stack for holding context
>
> Which call order are you referring to?
E.g.: http://nagoya.apache.org/bugzilla/show_bug.cgi?id=2213
> > - startEntity(String,...) name can start with
> > '%' denoting parameter entity
> > '#' denoting character entity ref
>
> The XNI javadoc details how an XNI-compliant component is
> required to behave. However, there is no requirement that
> an XNI parser be able to mark the start and end of character
> references. The Xerces2 reference implementation can report
> this by setting a feature but it's not on by default.
Right, if application enables it then it must be aware of
consequences (i.e. proper handling of entity refs starting with '#').
> > - could be introduced XNIEntityIOException that
> > should be propagated if a component gets IOException
> > while scanning some external entity, so it would in
> > fact convert fatal error (IOException is handled even
> > more strict than fatal error) to error. Open issue
> > what to do with pipeline components, they probably
> > cannot rollback to state prior entity entering.
>
> Hmmm... I need to think about this more.
>
> Thanks for the comments. If you find any more deficiencies
> in the javadoc (or accompanying docs in the "XNI Manual"),
> feel free to attach patches to your post.
Sometimes I am simply lazy.
Cc.
--
<address>
<a href="mailto:[EMAIL PROTECTED]";>Petr Kuzel</a> at Sun Microsystems
: <a href="http://xml.netbeans.org/";>XML module</a> and
: <a href="http://jini.netbeans.org/";>Jini</a> developer.</address>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
