https://bugzilla.xfce.org/show_bug.cgi?id=14576
--- Comment #12 from alexxcons <[email protected]> --- thanks, seems like you fixed it, now the patch works fine for me. Some further improvement suggestions for your patch to prevent memory leaking: - the return value of g_strconcat always need to be freed. Currently there is the risk that only one string is freed (if thunar_icon_factory_check_folder_icon returns on the last "if" statement) - as well when thunar_icon_factory_check_folder_icon return NULL, the srings build by g_strconcat need to be freed ( or when icon == NULL ) If you add a new patch to the issue which replaces old patches, you can select all your older patches in the "Obsoletes:" list, to mark them as not valid any more. However as said above, I would prefer a patch which makes use of gvfs metadata. We could recycle most of the nautilus code for that I think. -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Xfce-bugs mailing list [email protected] https://mail.xfce.org/mailman/listinfo/xfce-bugs
![[Xfce-bugs] [Bug 14576] Add support for folder.jpg](/search?l=xfce-bugs@xfce.org&q=subject:%22%5C%5BXfce%5C-bugs%5C%5D+%5C%5BBug+14576%5C%5D+Add+support+for+folder.jpg%22&o=newest){kind=link}
