On Mon, 24 Feb 2003, Marc Aurele La France wrote:
> On 24 Feb 2003, Nat Ersoz wrote:
>
> > While tracking down a bug, I encoutered these functions in:
> > programs/Xserver/hw/xfree86/vgahw/vgaHW.c:
>
> > void vgaHWLock(vgaHWPtr hwp)
> > {
> > /* Protect CRTC[0-7] */
> > hwp->writeCrtc(hwp, 0x11, hwp->readCrtc(hwp, 0x11) & ~0x80);
> > }
>
> > void vgaHWUnlock(vgaHWPtr hwp)
> > {
> > /* Unprotect CRTC[0-7] */
> > hwp->writeCrtc(hwp, 0x11, hwp->readCrtc(hwp, 0x11) | 0x80);
> > }
>
> > Every reference I can find on the sbuject, (specifically Ferraro's book,
> > 3rd ed, along with many HTML references) indicate that this logic is
> > reversed. That is, for CRTC reg 0x11 bit 7: 1=disable, 0=enable writing
> > to CRTC regs[0-7].
>
> > Comments?
>
> You are absolutely correct. I've just committed a change to correct this.
> Thanks for pointing out the problem.
Is it safe to do that this close to a release ?
There could be bugs that didn't get a chance to do anything because
the hardware was locked.
--
Dr. Andrew C. Aitchison Computer Officer, DPMMS, Cambridge
[EMAIL PROTECTED] http://www.dpmms.cam.ac.uk/~werdna
_______________________________________________
XFree86 mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/xfree86
