That
doesn't look thread-safe to me. You'd need to somehow synchronize access to
getLogger() to eliminate a race-condition on the if(logger == null)
test.
While
its a bit more typing, I prefer:
private static Logger logger =
LogFactory.getLogger(MyClass.class);
or
private static Logger logger =
LogFactory.getLogger(MyClass.class.getName());
No
threading issues and is pretty easy to read and understand.
--Kevin
-----Original Message-----As I mentioned in my previous message, this is a poor way to obtain a logger, especially if you have deep inheritance heirarchies. Since I'm a big fan of OO programming, and my heirarchies are especially deep, I find the static way of obtaining a logger invalid.
From: Kevin Ross [mailto:[EMAIL PROTECTED]
Sent: Tuesday, November 19, 2002 2:18 PM
To: Vladimir R. Bossicard; [EMAIL PROTECTED]
Subject: Re: LogFactory.getLogger()
Try this:
public class AbstractLoggable{
private static transient Logger logger;
protected Logger getLogger(){
if( logger == null ){
logger = Logger.getLogger(getClass());
}
return logger;
}
}
whallah! efficient OO programming with an accessor for subclasses and the proper class name to go with it!
-Kevin Ross
Vladimir R. Bossicard wrote:
Logger.getLogger(getClass()) at least, whether or not you use the string name is of no consequence.have you ever tried to call a non-static method within a static reference? if you get this working: private static Log log = LogFactory.getLog(getClass()); I give you a high-five. -Vladimir -- Vladimir R. Bossicard www.bossicard.com
