Just wanted to post a few nits encountered while building xlog on macOS:
> error: unknown warning option '-Wno-unused-but-set-variable'; did you mean > '-Wno-unused-const-variable'? > > > * removed from configure reran configure* > > callbacks_mainwindow_toolbar.c:343:34: error: equality comparison with > extraneous parentheses > [-Werror,-Wparentheses-equality] > if ((preferences.awardsiota == 1)) > ~~~~~~~~~~~~~~~~~~~~~~~^~~~ > callbacks_mainwindow_toolbar.c:343:34: note: remove extraneous parentheses > around the comparison to silence > this warning > > > * removed all such (( )) pairs * > > > > callbacks_mainwindow_qsoframe.c:402:16: error: comparison of unsigned > expression >= 0 is always true > [-Werror,-Wtautological-compare] > if (bandenum >= 0) > ~~~~~~~~ ^ ~ > callbacks_mainwindow_qsoframe.c:433:16: error: comparison of unsigned > expression >= 0 is always true > [-Werror,-Wtautological-compare] > if (modeenum >= 0) > ~~~~~~~~ ^ ~ > > * removed the tests* > > > hamlib-utils.c:625:30: error: length modifier 'L' results in undefined > behavior or no effect with 'd' > conversion specifier [-Werror,-Wformat] > g_string_printf (digits, "%Ld", programstate.rigfrequency); > ~^~ > hamlib-utils.c:625:30: note: did you mean to use 'll'? > > * change to ll* Otherwise it built and runs fine. I have to say overall this is one of the very cleanest C programs I have seen in a long time. Well done. 73, Elwood, WB0OEW
_______________________________________________ Xlog-discussion mailing list Xlog-discussion@nongnu.org https://lists.nongnu.org/mailman/listinfo/xlog-discussion
