[ http://issues.apache.org/jira/browse/XMLRPC-101?page=comments#action_12424752 ] Jochen Wiedmann commented on XMLRPC-101: ----------------------------------------
There's nothing wrong with using Java 1.4 (or even 1.5 features), as long as the respective code is clearly separated. Take, for example, the CharSetXmlWriter. That's one important reason for using the factory approach: The factory allows you to check, which Java version you are running. Based on the check, the proper implementation will be returned. In other words, please be so kind to modify your patch in the following manner: - First of all, for now forget about the lite and commons classes. Sorry, that I haven't mentioned this earlier. It simplifies and reduces your work and may well be deferred until we agree on the interface. - In the XmlRpcSunHttpTransportFactory, check whether one is running 1.4 or 1.5. The check should be implemented by validating the existence of appropriate classes. - Create 1.4 and 1.5 specific subclasses of XmlRpcSunHttpTransportFactory. These are the proper locations for your patches. > Possibility to subclass XmlRpcSunHttpTransport for added functionality > ---------------------------------------------------------------------- > > Key: XMLRPC-101 > URL: http://issues.apache.org/jira/browse/XMLRPC-101 > Project: XML-RPC > Issue Type: Improvement > Components: Source > Affects Versions: 3.0rc1 > Reporter: Julio Francisco Veronelli > Priority: Trivial > Attachments: ssl.patch > > > Could it be possible to make the URLConnection in class > org.apache.xmlrpc.client.XmlRpcSunHttpTransport protected instead of private? > That is: > protected URLConnection conn; > REASON: > That way is much easier to subclass for added functionality. In particular, > i'm subclassing it to set a java.net.Proxy or a java.security.KeyStore used > for setting a SSL connection. > In XML-RPC 3.0a1 it was easy to do, all that was needed was to subclass > method newConnection(). In 3.0RC1 that method is gone, and overwriting > sendRequest(XmlRpcRequest) is not possible, since conn is private. > I tried also extending XmlRpcHttpTransport, but it is not possible, because > org.apache.xmlrpc.client.XmlRpcStreamTransport.RequestWriter is protected and > cannot be accessed. > Thanks in advance. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
