[ 
http://issues.apache.org/jira/browse/XMLRPC-101?page=comments#action_12424986 ] 
            
Julio Francisco Veronelli commented on XMLRPC-101:
--------------------------------------------------

Sorry, the example is wrong, should read:

XmlRpcTransportFactory t = new XmlRpcSun14HttpTransportFactory(pClient);

or,

XmlRpcTransportFactory t = XmlRpcSunHttpTransportFactory.getInstance(pClient);
if (t instanceof XmlRpcSun15HttpTransportFactory) { /* set proxy or ssl factory 
*/ }

As a sidenote, I'm not extending XmlRpcSunHttpTransportFactory from the other 
two factories, since they should be completely different factories from one 
another (and no unnecessary private fields are created). And as for features, 
methods can be added or deprecated from one version of Java SE to another, 
that's why XmlRpcSunHttp15TransportFactory does not extend from 
XmlRpcSun14HttpTransportFactory (same happens in XmlRpcSun15HttpTransport and 
XmlRpcSun14HttpTransport).

Cheers.

> Possibility to subclass XmlRpcSunHttpTransport for added functionality
> ----------------------------------------------------------------------
>
>                 Key: XMLRPC-101
>                 URL: http://issues.apache.org/jira/browse/XMLRPC-101
>             Project: XML-RPC
>          Issue Type: Improvement
>          Components: Source
>    Affects Versions: 3.0rc1
>            Reporter: Julio Francisco Veronelli
>         Assigned To: Jochen Wiedmann
>            Priority: Trivial
>         Attachments: ssl.patch, sunhttp.zip
>
>
> Could it be possible to make the URLConnection in class 
> org.apache.xmlrpc.client.XmlRpcSunHttpTransport protected instead of private? 
> That is:
> protected URLConnection conn;
> REASON:
> That way is much easier to subclass for added functionality. In particular, 
> i'm subclassing it to set a java.net.Proxy or a java.security.KeyStore used 
> for setting a SSL connection.
> In XML-RPC 3.0a1 it was easy to do, all that was needed was to subclass 
> method newConnection(). In 3.0RC1 that method is gone, and overwriting 
> sendRequest(XmlRpcRequest) is not possible, since conn is private.
> I tried also extending XmlRpcHttpTransport, but it is not possible, because 
> org.apache.xmlrpc.client.XmlRpcStreamTransport.RequestWriter is protected and 
> cannot be accessed.
> Thanks in advance.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to