Thanks for cleaning it up :). Looks great now.
I meant to have separate key files for der, pem, pkcs8-der and pkcs8-pem
but forgot about it in a hurry. What I sent had still some stuff from the previous set of
changes.
thanks again
-Tej
Aleksey Sanin wrote:
_______________________________________________ xmlsec mailing list [EMAIL PROTECTED] http://www.aleksey.com/mailman/listinfo/xmlsec Hi, Tej!
Thanks a lot for the patch! I have applied it and checked it in
with following changes:
0) Minor changes in src/openssl/apps.c to make code more readable
(there is no PKCS#8 format for certificates :) ).
1) You was right when you suggested to use "--privkey-*" options.
This makes the life much easier in the test scripts. And since there is
an ability to have two names for each option, I used both: "--pkcs8-*" and
"--privkey-p8-*".
2) With fixing 1) I was able to slightly simplify all test scripts.
3) I would prefer to have old *.pem and *.der files in place for testing.
I've added the pkcs8 files as *.p8-pem and *.p8-der. I also have changed
password to standard "secret" (used in some other test cases).
The changes are checked in CVS. Please take a look to make sure that
my changes to your changes are ok for you :)
Aleksey
