Hi Harald

On 2015-02-07, Harald Brabenetz wrote:

> For the CompareMatcher I need also a
> ComparisonControllers.StopWhenSimilar implementation:
> https://github.com/brabenetz/xmlunit/commit/8bbda11263c1385ee97876235c4f1de63babe05e
> Let me know what you think. I will then create a separate pull
> request.

Sounds reasonable.

> I think the Hamcrest CompareMatcher should always stop the comparison
> depending on "checkForIdentical()" or "checkForSimilar()".  I think a
> public method like ".withComparisonController()" is only confusing for
> the Hamcrest CompareMatcher.

Yes, this is probably correct.  For the matcher the
isIdentical/SimilarTo methods cover the use cases of what you'd do with
a custom ComparisonController otherwise.

Stefan

------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Xmlunit-general mailing list
Xmlunit-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xmlunit-general

Reply via email to