Hi,

I would like to make the CompareMatcher extendable.
This means that the constructor and two methods must be protected instead 
private.
I created an Example usage in the UnitTest:
https://github.com/brabenetz/xmlunit/commit/8479be3c9192bac073460002f55a6f5c1238c46b#diff-be4be35ef4f91a64f60bae29d9c22e8fR343

This example is basically what I do with the Matcher on my current Project: I 
write the test-Input into the FileSystem, where I can manual review it.
And when the changes are OK I can simply overwrite my control-File with the 
written Test-File.

Alternative (CompareMatcher not extendable because of private constructor) I 
could write a custom "assertThat()" method in my current project which would do 
the same thing.
At least for my current project it is cleaner to extends the Matcher: In all my 
Tests I only need the extended Matcher instead of the compination of the 
CompareMatcher AND a custom "assertThat" method.

On the other hand it is more difficult to maintain a Class which can be 
extended.

Please let me know what you think.

with friendly regards,
Harald

------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk
_______________________________________________
Xmlunit-general mailing list
Xmlunit-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xmlunit-general

Reply via email to