Hi, On Fri, Oct 02, 2009 at 02:54:57PM -0700, Jamey Sharp wrote: > I get the impression from glancing at the code that you're right, but > xf86RandRSetConfig begins with > > miPointerGetPosition(inputInfo.pointer, &px, &py); > > and this if block ends with > > (*pScreen->SetCursorPosition) (inputInfo.pointer, pScreen, ... > > so there's quite a bit more involved in such a change. > > Meanwhile, this simple patch at least makes this call consistent with > the two near it, and fixes the compiler warning.
To be honest, I'd rather keep the warning in this case, so we know that the code needs to be fixed. > I suspect most of this code could go away anyway, in a world where > people rarely use viewport panning. I'd guess the real problem is that > xf86SwitchMode goes to a bunch of trouble to move all the pointers > around and then this function feebly attempts to put one of them back. The panning code is new. :\ Cheers, Daniel
pgpfMWicMv9I8.pgp
Description: PGP signature
_______________________________________________ xorg-devel mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-devel
