On Fri, Oct 02, 2009 at 02:20:33PM -0700, Jamey Sharp wrote: > In both functions, "answer" was uninitialized if "compsize" was 0, but in > that case __GLX_SEND_VOID_ARRAY(compsize) results in a call to > WriteToClient for 0 bytes, which returns immediately without examining the > "answer" argument. So initializing to a null pointer is as good as > anything else. > > Signed-off-by: Jamey Sharp <[email protected]> > --- > On Fri, Oct 02, 2009 at 11:09:49PM +0200, Rémi Cardona wrote: > > > - char *answer, answerBuffer[200]; > > > + char *answer = 0, answerBuffer[200]; > > > > Why not NULL instead of 0? > > Personal habit. Here's a revised patch.
Thanks. Acked-by: Daniel Stone <[email protected]>, merged into ~daniels/xserver. Cheers, Daniel
pgpOqxXwAMfIx.pgp
Description: PGP signature
_______________________________________________ xorg-devel mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-devel
