On Thu, 2009-11-19 at 17:48 +0200, Tiago Vignatti wrote: > On Wed, Nov 18, 2009 at 08:28:56PM +0100, ext Adam Jackson wrote: > > + > > +#define PCI_CLASS_BRIDGE 0x06 > > +#define PCI_SUBCLASS_BRIDGE_PCI 0x04 > > Shouldn't we move all PCI config space definitions to some common place? > > For instance pcitutils already defines this particular macro as > PCI_BASE_CLASS_BRIDGE and we could use that. Well, seems that we're slowly > deprecating pciutils, but we should have the same header file in libpciaccess.
Icky, yeah. It makes sense for us to have a header for this stuff, but I don't like the idea of conflicting or redundant definitions with pciutils. Someone should think this through. > Besides the header thing, it's: > > Acked-by: Tiago Vignatti <[email protected]> Pushed, thanks. - ajax
signature.asc
Description: This is a digitally signed message part
_______________________________________________ xorg-devel mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-devel
