On Tue, 15 Dec 2009 09:32:58 -0500, Adam Jackson <[email protected]> wrote:

> Well, not devices, at least not for silken-enabled servers.  But yes.
> And right now, it does; MaxClientFd ends up being getdtablesize()-1,
> which is all the file descriptors you can pass to select.

I was just thinking that 'MaxClientFd' was a confusing name as it's
possible for some non-client fd to be present in the array.

> I considered trying to keep MaxClientFd clamped to the smallest correct
> number in a second patch, but it looks to be literally not worth the
> effort.  I could not measure the difference between MaxClientFd of 1024
> and of 16 in x11perf -noop on a recentish laptop.  Would be interesting
> to know the numbers on a less macho device though.

Yeah, you're really just asking the kernel to discover a bunch of zeros
in the select mask, something which clearly doesn't take a lot of
computrons.

In any case, I'd bet that x11perf -prop or x11perf -pointer would be
better able to detect any difference here; you really want to hammer the
select syscall, and -noop won't end up calling that very often.

-- 
[email protected]

Attachment: pgp9TjKlyn9Fa.pgp
Description: PGP signature

_______________________________________________
xorg-devel mailing list
[email protected]
http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to