On Mon, 14 Dec 2009 15:19:48 -0500, Adam Jackson <[email protected]> wrote:
> ... which is sort of a funny thing to say. MaxClients was actually the > maximum file descriptor number to pass to select(); MAXCLIENTS is the > client count limit. Typical servers have quite a few file descriptors > open below MAXCLIENTS that are not clients (input devices, mostly), > which means you end up losing client slots. > > Rename MaxClients to reflect its true nature, and don't clamp it to > MAXCLIENTS. Yeah, good stuff. > -int MaxClients = 0; > +int MaxClientFd = 0; Didn't we chat and agree to use something more obviously related to the select call here? Like MaxActiveFd or MaxSelectFd? This isn't MaxClientFd as it's possible (if unlikely) that the max fd isn't a client one. I'd also take MaxSelect as it relates to the MAXSELECT define. -- [email protected]
pgp6nFcsFq3Mm.pgp
Description: PGP signature
_______________________________________________ xorg-devel mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-devel
