Hi,
There are 41 driver modules with the line:
sdkdir=$(pkg-config --variable=sdkdir xorg-server)
Following up on review
http://lists.x.org/archives/xorg-devel/2009-November/003711.html
From Dan Nicholson:
This should be
sdkdir=`$PKG_CONFIG --variable=sdkdir xorg-server`
1. The user may need to use a specific pkg-config or pass custom
arguments to it. Think multiarch or cross-compiling scenarios.
2. Backticks (``) are supported by all shells while $() command
substitution is for strictly POSIX conforming shells. We don't
need to
limit ourselves to that subset.
There are 12 drivers who are effectively using this line:
joystick, synaptics, glint, intel, mach64, mga, r128, savage,
sis, tdfx, xgi, xgixp
I intend to apply this patch to all 12 of them. Other patches for the
remainder modules will follow.
The reference patch is from input-synaptics
>From c4dfdfc442c2c61b443ed9dba41895b7b2546b6c Mon Sep 17 00:00:00 2001
From: Gaetan Nadon <[email protected]>
Date: Tue, 15 Dec 2009 21:37:43 -0500
Subject: [PATCH] configure.ac: use backticks rather than $() for cmd subs
Use "$PKG_CONFIG" rather than hard coded "pkg-config"
Signed-off-by: Gaetan Nadon <[email protected]>
---
configure.ac | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/configure.ac b/configure.ac
index 2d20cdc..4e63006 100644
--- a/configure.ac
+++ b/configure.ac
@@ -95,7 +95,7 @@ XORG_DRIVER_CHECK_EXT(XINPUT, inputproto)
# Checks for pkg-config packages
PKG_CHECK_MODULES(XORG, xorg-server xproto $REQUIRED_MODULES)
-sdkdir=$(pkg-config --variable=sdkdir xorg-server)
+sdkdir=`$PKG_CONFIG --variable=sdkdir xorg-server`
AC_SUBST([sdkdir])
PKG_CHECK_MODULES(XORG16, [xorg-server >= 1.6],
--
1.6.0.4
_______________________________________________
xorg-devel mailing list
[email protected]
http://lists.x.org/mailman/listinfo/xorg-devel
