On Thu, Dec 17, 2009 at 07:47:52PM -0500, Gaetan Nadon wrote: > There are 41 driver modules with the line: > sdkdir=$(pkg-config --variable=sdkdir xorg-server) > > Following up on review > http://lists.x.org/archives/xorg-devel/2009-November/003711.html > From Dan Nicholson: > This should be > > sdkdir=`$PKG_CONFIG --variable=sdkdir xorg-server` > > 1. The user may need to use a specific pkg-config or pass custom > arguments to it. Think multiarch or cross-compiling scenarios. > > 2. Backticks (``) are supported by all shells while $() command > substitution is for strictly POSIX conforming shells. We don't > need to > limit ourselves to that subset. > > There are 12 drivers who are effectively using this line: > joystick, synaptics, glint, intel, mach64, mga, r128, savage, > sis, tdfx, xgi, xgixp > > I intend to apply this patch to all 12 of them. Other patches for the > remainder modules will follow. > > The reference patch is from input-synaptics
Acked-by: Daniel Stone <[email protected]>
pgp7I5bpg1ueg.pgp
Description: PGP signature
_______________________________________________ xorg-devel mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-devel
