Resending. On Thu, 2009-12-17 at 19:48 -0500, Gaetan Nadon wrote:
> Hi, > > There are 41 driver modules with the line: > > sdkdir=$(pkg-config --variable=sdkdir xorg-server) > > > Following up on review > http://lists.x.org/archives/xorg-devel/2009-November/003711.html > > > From Dan Nicholson: > This should be > > sdkdir=`$PKG_CONFIG --variable=sdkdir xorg-server` > > 1. The user may need to use a specific pkg-config or pass > custom > arguments to it. Think multiarch or cross-compiling scenarios. > > 2. Backticks (``) are supported by all shells while $() > command > substitution is for strictly POSIX conforming shells. We don't > need to > limit ourselves to that subset. > > > There are 35 modules who are not using that line at all. Rather than > making dead code more portable, this patch removes this statement. I > have done extensive grepping and tested with make distcheck: > > acecad, aiptek, keyboard, mouse, vmmouse, ast, ati, chips, cirrus, > dummy, fbdev, geode, i128, i740 > neomagic, newport, nv, rendition, s3, s3virge, siliconmotion, sisusb > suncg3, suncg6, suncg14, sunffb, sunleo, suntcx, tga, trident, tseng, > v4l > vmware, voodoo, wsfb > > I intend to apply this patch to all 35 of them. Other patches for the > remainder modules will follow. > > The reference patch is from video-ati > > _______________________________________________ > xorg-devel mailing list > [email protected] > http://lists.x.org/mailman/listinfo/xorg-devel
_______________________________________________ xorg-devel mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-devel
