Hi,
There are 41 driver modules with the line:
sdkdir=$(pkg-config --variable=sdkdir xorg-server)
Following up on review
http://lists.x.org/archives/xorg-devel/2009-November/003711.html
From Dan Nicholson:
This should be
sdkdir=`$PKG_CONFIG --variable=sdkdir xorg-server`
1. The user may need to use a specific pkg-config or pass custom
arguments to it. Think multiarch or cross-compiling scenarios.
2. Backticks (``) are supported by all shells while $() command
substitution is for strictly POSIX conforming shells. We don't
need to
limit ourselves to that subset.
There are 35 modules who are not using that line at all. Rather than
making dead code more portable, this patch removes this statement. I
have done extensive grepping and tested with make distcheck:
acecad, aiptek, keyboard, mouse, vmmouse, ast, ati, chips, cirrus,
dummy, fbdev, geode, i128, i740
neomagic, newport, nv, rendition, s3, s3virge, siliconmotion, sisusb
suncg3, suncg6, suncg14, sunffb, sunleo, suntcx, tga, trident, tseng,
v4l
vmware, voodoo, wsfb
I intend to apply this patch to all 35 of them. Other patches for the
remainder modules will follow.
The reference patch is from video-ati
>From 790b16ad3bbeadc585122556a3ed663a987256a9 Mon Sep 17 00:00:00 2001
From: Gaetan Nadon <[email protected]>
Date: Wed, 16 Dec 2009 15:52:18 -0500
Subject: [PATCH] configure.ac: remove unused sdkdir=$(pkg-config...) statement
The sdkdir varaible isn't use, so remove the statement
Signed-off-by: Gaetan Nadon <[email protected]>
---
configure.ac | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/configure.ac b/configure.ac
index 6b3c4c6..482fbeb 100644
--- a/configure.ac
+++ b/configure.ac
@@ -96,7 +96,6 @@ PKG_CHECK_MODULES(XEXT, [xextproto >= 7.0.99.1],
HAVE_XEXTPROTO_71="yes"; AC_DEFINE(HAVE_XEXTPROTO_71, 1, [xextproto 7.1 available]),
HAVE_XEXTPROTO_71="no")
AM_CONDITIONAL(HAVE_XEXTPROTO_71, [ test "$HAVE_XEXTPROTO_71" = "yes" ])
-sdkdir=$(pkg-config --variable=sdkdir xorg-server)
# Checks for libraries.
--
1.6.0.4
_______________________________________________
xorg-devel mailing list
[email protected]
http://lists.x.org/mailman/listinfo/xorg-devel
