On Thu, Mar 25, 2010 at 3:14 PM, Peter Hutterer <[email protected]> wrote: > On Thu, Mar 25, 2010 at 07:14:10AM -0700, Dan Nicholson wrote: >> On Thu, Mar 25, 2010 at 6:52 AM, Alan Coopersmith >> <[email protected]> wrote: >> > Peter Hutterer wrote: >> >> +if XSERVER18 >> >> +confdir = $(sysconfdir)/xorg.conf.d >> >> +conf_DATA = 00-evdev.conf >> >> +endif >> > >> > Should it install when building against older X servers as well, so that >> > upgrades work, or did we break ABI and require rebuilding input drivers >> > when going from 1.7 to 1.8 anyway? >> >> NewInputDeviceRequest breaks ABI to add the InputAttributes parameter, >> so I think we'll be OK. > > no driver except wacom uses this though, and even then it's a compile-time > guard, not a configure-time guard. You could still run an older version of > evdev, make clean && make install and you're done. > Remember that no driver actually has _active_ support for hal or udev, it's > all the same to them. Wacom has a little piece of code, but that's just a > strcmp() for "hal" and "udev". > > The alternative to this patch is to move the 00-evdev.conf (or > 10-evdev.conf) into the server and install it whenever udev is enabled. > Would that work for you?
I think this patch in evdev is the right thing since it's a property of this driver and not the server to go claiming device support. I also think installing it only on xserver-1.8+ is right since there's no xorg.conf.d/InputClass on previous servers and the driver built against previous servers will not run against 1.8+ due to ABI_XINPUT_VERSION bumps (maybe I'm wrong on the last point). -- Dan _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
