2010/4/10 Michel Dänzer <[email protected]>: > On Fri, 2010-04-09 at 14:18 -0400, Kristian Høgsberg wrote: >> Now that glx doesn't call DRI2DestroyDrawable anymore, we don't need to >> force a specific resource destruction order in the DestroyWindow hook. > > I don't think DRI2DestroyDrawable was the only reason for this, see e.g. > commit 2075d4bf9e53b8baef0b919da6c44771220cd4a5 ('glx: If a destroyed > window is bound to the current context, make it not current.') and the > bug report referenced by it.
There's no bug report reference in that commit nor is there one in 120286aef59dabdb7c9fa762e08457e5cc8ec3a6, though that would have been very useful in this case. I don't see how 2075d4bf9e53b8baef0b919da6c44771220cd4a5 relates to resource destruction ordering between the DRI2Drawable and the GLX drawable. The DrawableGone only references the GLX drawable that's being destroyed. There are no references to other resources that may have been destroyed at that time, except for the DRI2Drawable reference in the call to glxPriv->destroy(), which is now fixed. Kristian _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
