On Thu, 2010-04-15 at 08:26 -0400, Kristian Høgsberg wrote: > 2010/4/15 Kristian Høgsberg <[email protected]>: > > 2010/4/15 Michel Dänzer <[email protected]>: > >> On Thu, 2010-04-15 at 07:58 -0400, Kristian Høgsberg wrote: > >>> 2010/4/15 Michel Dänzer <[email protected]>: > >>> > On Wed, 2010-04-14 at 15:13 -0400, Kristian Høgsberg wrote: > >>> >> > >>> >> The real fix is the patch from attachment 25038, not the DestroyWindow > >>> >> hook. If the context is destroyed first, it will remove itself from > >>> >> the glxAllContexts list so the DrawableGone destructor won't touch it. > >>> >> On the other hand, if the drawable is destroyed first, thanks to your > >>> >> patch, it will detach itself from the context properly so context > >>> >> destruction (whether at resource cleanup time or at client shutdown > >>> >> time) wont touch a free drawable. > >>> > > >>> > Right, but that will only work if DestroyWindow of the X window also > >>> > destroys the corresponding GLX drawable. Are you saying that's > >>> > guaranteed anyway now, and have you tested that none of MacSlow's > >>> > rgba-glx demos crashes the X server on exit anymore without this hook? > >>> > >>> Yes, the GLX drawable is a client allocated resource that gets cleaned > >>> up when the client exits. > >> > >> And if it doesn't? :) What's to stop a client from binding a window to a > >> GLX context, destroying the X window and then doing more stuff with the > >> GLX context? > > > > We handle that in DrawableGone. You wrote that patch. > > Just to clarify, when a window is destroyed, all resources with the > same ID are destroyed. So as long as there are no dependencies > between resource destructors for the different types of resources with > that ID, there should be no problem.
It all sounds great in theory, but I still don't understand why the hook was necessary (or at least made a difference) when I added it, but that should no longer be the case now. :( Is it that the GLX drawable could have a different ID back then but no longer can now? -- Earthling Michel Dänzer | http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
