Mikhail Gusarov wrote: > The following changes since commit 482b19329fac5e311fe0423e58f3e8c573b66114: > Gaetan Nadon (1): > config: update AC_PREREQ statement to 2.60 > > are available in the git repository at: > > git://anongit.freedesktop.org/~dottedmag/libXdmcp cleanups
I've pushed to master the smaller set of patches I had put out for review at the same time, so now there are merge conflicts from a pull. For now, I've just reviewed from the web view at http://cgit.freedesktop.org/~dottedmag/libXdmcp/log/?h=cleanups > Mikhail Gusarov (4): > Get rid of Xalloc/Xrealloc/Xfree from X server or Xlib Besides the Windows issues mentioned earlier, I also wonder if you've checked all the callers of libXdmcp to make sure they don't free directly but only through the libXdmcp calls. Since we've never shipped libXdmcp man pages or other documentation that I know of, we can't claim that the documented interfaces require it, so have to hope all the callers followed the implied conventions. > Reshuffle functions, nuke lot of 8/16/32 files This seems reasonable, though would need resyncing with current master, and currently depends on the previous patch. If it was rebased to current master without the Xalloc/Xfree changes, I think it would be okay to go ahead while we figure those out. (Or you can wait and do them in the current order - up to you.) > Nuke RCS tags Reviewed-by: Alan Coopersmith <[email protected]> > Unifdef STREAMSCONN and Lynx My patch killed Lynx already. As for STREAMSCONN, I think SCO was the last actively supported platform that supported it, but I don't think libXdmcp should remove it as long as libX11 & Xserver still have their support in. Though as noted in a recent xcb thread, libxcb (and libX11 built on top of libxcb) now only support the socket-based transports (TCP & Unix), so whether we should declare the other connection types deprecated and/or remove them altogether for X11R7.6 is something to discuss in the larger context than just libXdmcp. -- -Alan Coopersmith- [email protected] Oracle Solaris Platform Engineering: X Window System _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
