On Fri, May 21, 2010 at 7:43 AM, Tiago Vignatti <tiago.vigna...@nokia.com> wrote: > Hi, > > This set keeps with the cleaning up on the Xorg bus code. The most apparent > benefit is that it makes xf86AutoConfig and xf86Helper independent from pci > code, moving it to a more meaningful place (xf86pciBus.c). > > This patch set is a preparation of the rework of the bus entity code (RAC > remnants) that I'll be planing to do some time soon. Will be a bit tought due > it touches a lot on the driver side -- can we merge them in the xserver for > 1.10, please? :) > > > All patches should be very trivial to review, please do so: > > git://anongit.freedesktop.org/~vignatti/xserver [bus-cleanup-take2] > http://cgit.freedesktop.org/~vignatti/xserver/log/?h=bus-cleanup-take2 >
Looks good to me. Reviewed-by: Alex Deucher <alexdeuc...@gmail.com> for the series. > > Thanks, > > Tiago > > Tiago Vignatti (11): > xfree86: bus: remove unused pci macros > xfree86: bus: remove unused headers > xfree86: bus: move IOADDRESS definition to a common header file > xfree86: bus: remove superfluous and confused structures in BusRec > xfree86: bus: delete useless xf86FindPrimaryDevice > xfree86: bus: remove useless field from EntityRec > xfree86: remove all kind of bus and PCI dependency from the common helper > file > xfree86: remove BUS_ISA type given we don't support anymore > xfree86: organize and group all pci related stuff inside xf86.h > xfree86: no need to check for the configuration case when matching devices > xfree86: move all pci code from auto configurator into a meaningful location > > hw/xfree86/common/xf86.h | 57 ++-- > hw/xfree86/common/xf86AutoConfig.c | 248 +----------- > hw/xfree86/common/xf86Bus.c | 45 +-- > hw/xfree86/common/xf86Bus.h | 1 - > hw/xfree86/common/xf86Configure.c | 2 - > hw/xfree86/common/xf86Helper.c | 505 ----------------------- > hw/xfree86/common/xf86Priv.h | 4 - > hw/xfree86/common/xf86VGAarbiter.c | 2 +- > hw/xfree86/common/xf86pciBus.c | 762 > ++++++++++++++++++++++++++++++++++- > hw/xfree86/common/xf86pciBus.h | 1 + > hw/xfree86/common/xf86sbusBus.c | 8 +- > hw/xfree86/common/xf86str.h | 13 +- > hw/xfree86/os-support/bus/Pci.c | 1 - > hw/xfree86/os-support/bus/Pci.h | 8 - > hw/xfree86/os-support/bus/xf86Pci.h | 3 +- > hw/xfree86/vbe/vbe.c | 1 - > 16 files changed, 796 insertions(+), 865 deletions(-) > > _______________________________________________ > xorg-devel@lists.x.org: X.Org development > Archives: http://lists.x.org/archives/xorg-devel > Info: http://lists.x.org/mailman/listinfo/xorg-devel > _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel