On Fri, May 21, 2010 at 04:55:23PM +0200, ext Mark Kettenis wrote:
> > From: Tiago Vignatti <tiago.vigna...@nokia.com>
> > Date: Fri, 21 May 2010 14:43:16 +0300
> >
> > IOADDRESS type definition encompass more than just pci code, so move it to
> > common.
> >
> > diff --git a/hw/xfree86/os-support/bus/xf86Pci.h
> > b/hw/xfree86/os-support/bus/xf86Pci.h
> > index ce1336b..a9a2779 100644
> > --- a/hw/xfree86/os-support/bus/xf86Pci.h
> > +++ b/hw/xfree86/os-support/bus/xf86Pci.h
> > @@ -235,7 +235,6 @@
> >
> > /* Primitive Types */
> > typedef unsigned long ADDRESS; /* Memory/PCI address */
> > -typedef unsigned long IOADDRESS; /* Must be large enough for a pointer */
> > typedef unsigned long PCITAG;
>
> Moving IOADDRESS over, but leaving the other ibviously related ones
> behind, seems a bad idea to me.
All right, I'll do it.
But honestly I've done this initial patch a bit against my will because all
this typedefs should be only constrained inside PCI code, but with the current
code base seems really tough :(
Tiago
_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
