On Wed, May 26, 2010 at 04:57:02PM -0700, Pierre-Loup A. Griffais wrote: > ValidateTree can be pretty expensive; gnome-shell floods the server with > input shape requests when animating windows, so that change makes it > perform a lot better. > > Aaron suggested Keith and Adam as reviewers; are the SetWinSize, > SetBorderSize, ResizeChildrenWinSize also unneeded when changing the > input shape? The only thing that looks needed for sure is > CheckCursorConfinement(), but I have my doubts about the rest.
You don't need to call any of SetWinSize, SetBorderSize, or ResizeChildrenWinSize, which are also moderately hostile. So if you skipped those three for changes only to the input shape: Reviewed-by: Daniel Stone <[email protected]> Cheers, Daniel
pgpfDPTsJXuL2.pgp
Description: PGP signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
