On Wed, 26 May 2010 16:57:02 -0700, "Pierre-Loup A. Griffais" <[email protected]> wrote: > ValidateTree can be pretty expensive; gnome-shell floods the server with > input > shape requests when animating windows, so that change makes it perform a lot > better. > > Aaron suggested Keith and Adam as reviewers; are the SetWinSize, > SetBorderSize, > ResizeChildrenWinSize also unneeded when changing the input shape? The only > thing that looks needed for sure is CheckCursorConfinement(), but I have my > doubts about the rest.
The only thing necessary when changing the input shape is WindowsRestructured and CheckCursorConfinement, both of which deal with input. None of the rest of that function is necessary at all. I'd suggest not abusing 'WasViewable' for this purpose and instead simply wrapping most of the function in the test of which shape is being set. -- [email protected]
pgp4f9pxKRaqG.pgp
Description: PGP signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
