On Wed, 22 Sep 2010 16:10:49 -0400, Adam Jackson <[email protected]> wrote:
> +static struct pci_io_handle *
> +pci_device_freebsd_open_legacy_io(struct pci_io_handle *ret,
> + struct pci_device *dev, pciaddr_t base,
> + pciaddr_t size)
> +{
> + ret->fd = open("/dev/io", O_RDWR);
> +
> + if (ret->fd < 0)
> + return NULL;
> +
> + ret->base = base;
> + ret->size = size;
> +
> + return ret;
> +}
That's a terrible API. Is this fixed in stone somewhere? Or can it just
return an error indication instead of NULL?
--
[email protected]
pgpmwOof0O63t.pgp
Description: PGP signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
