On Tue, Nov 16, 2010 at 00:09:09 +0100, Thierry Vignaud wrote:

> -     case 0x10de: case 0x12d2:   driverList[0] = "nv";       break;
> +     case 0x10de: case 0x12d2:
> +         switch (dev->device_id) {
> +         /* NV1 */
> +         case 0x0008:
> +         case 0x0009:
> +             driverList[0] = "vesa";

Not necessary, the fallback drivers are added to the list later anyway.

> +             break;
> +         /* NV3 */
> +         case 0x0018:
> +         case 0x0019:
> +             driverList[0] = "nv";
> +             break;
> +         default:
> +             driverList[0] = "nouveau";

Still need to keep nv here.

> +             break;
> +         }
> +         break;

I don't think this needs to be quite that complex.  If the chip is not
supported by the first driver it'll just fail in pciprobe and you'll try
the second one, and if that doesn't work either then you'll get vesa or
fbdev.  No need to replicate each driver's probe logic in the server.

Cheers,
Julien
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to