On Mon, Nov 15, 2010 at 3:13 PM, Thierry Vignaud <[email protected]> wrote: > On 16 November 2010 00:09, Thierry Vignaud <[email protected]> wrote: >>>> This patch selects nouveau by default for NVIDIA GPUs >>>> Also, don't treat DRI setup failure as an error for nouveau. >>> >>> Can you please split this patch in two parts since there are two >>> completely orthogonal changes? Also, it would be good if the commit >>> message explained why these changes are necessary. See: > > (...) > >> here you are: >> >> This patch default to a proper driver for nvidia cards considering that: > > And this patch make xorg not treat DRI setup failure as an error for nouveau : > > nouveau 3D support is quite new (needs latest mesa, new enough kernel with > the proper build options). > What's more, the DRM interface got broken several times > (see http://lwn.net/Articles/377953/) > > So treat faillure to set up DRI for nouveau gracefully.
I'd agree with not spamming the user's log when something is known to fail. For a distro, a hack to check the name of the driver and change a failure to a warning makes sense. However, I'm not sure this approach is appropriate for upstream. Let's see what driver developers have to say. -- Dan _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
