Hi, On Thu, Dec 30, 2010 at 07:19:31PM +0200, Pauli wrote: > I tryed to fix the indent problems. Too bad those fails have mixed tabs and > space. I'm not having tabs showing in editor so I didn't notice there anything > weird. (I have configured my editor to use linux kernel coding style by > default) > > Then I dropped the NoopDDA patches from the series. I'm working on better fix > that is a based on Daniel's diff but I want to have NULL check in register > time. > > Another improvement for WakeupHandlers that looks appealing would be providing > API to link fd directly to callback make it possible for server core to only > call wakeup handlers when there is something to read. xf86Wakeup already tries > to implement this but doesn't do it optimally. > > I also collected r-b tags that were offered for a few patches.
These all look good to me, except #12 which didn't build, and the cast warning in #5. I've fixed them up and have sent the new versions out to the list. If you could check that they're both OK, I can include them in my next pull request. Thanks for that! Cheers, Daniel
signature.asc
Description: Digital signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
