Hi, On Thu, Dec 30, 2010 at 07:19:40PM +0200, Pauli wrote: > @@ -383,7 +390,6 @@ miSpriteCloseScreen (int i, ScreenPtr pScreen) > pScreen->GetImage = pScreenPriv->GetImage; > pScreen->GetSpans = pScreenPriv->GetSpans; > pScreen->SourceValidate = pScreenPriv->SourceValidate; > - pScreen->BlockHandler = pScreenPriv->BlockHandler; > pScreen->InstallColormap = pScreenPriv->InstallColormap; > pScreen->StoreColors = pScreenPriv->StoreColors;
It's still good form to tear the block handler down, and there's no
reason it should run after CloseScreen. So, I'd say change this to:
if (pScreenPriv->BlockHandler)
pScreen->BlockHandler = pScreenPriv->BlockHandler;
Aside from that:
Reviewed-by: Daniel Stone <[email protected]>
Cheers,
Daniel
signature.asc
Description: Digital signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
