On Fri, Mar 04, 2011 at 04:05:21PM -0500, ext Adam Jackson wrote: > Remove the UNDRAWABLE_WINDOW macro (which was just needlessly cute) and > always check ->class to decide if a window is InputOnly or InputOutput. > ->type is now always either window or pixmap.
I wonder how many places assume that 'type != DRAWABLE_WINDOW && type != DRAWABLE_PIXMAP' type of checks would catch InputOnly windows? At least dri2 relies on that in DRI2CreateDrawable(). Well, actually DRI2CreateDrawable() leaks memory if it encounters UNDRAWABLE_WINDOW, but that's just a bug that should be fixed anyway. I fear you pretty much have to review every piece of code that checks the drawable type. -- Ville Syrjälä _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
