Adam Jackson <[email protected]> writes: > The mask argument was almost always 0 or (equivalently) M_ANY.
Are they actually equivalent? If you pass 0, then the code uses M_DRAWABLE, which actually means "drawable, which is not an InputOnly window". But if you pass M_ANY, then InputOnly windows are also returned, as they have resource class RC_DRAWABLE too. The patch makes dixLookupDrawble() behave as if M_ANY was passed, but code that passed 0 would need an additional check that the returned drawable was not an InputOnly window. Alternatively, maybe dixLookupDrawable() could be changed to never return InputOnly windows, and then have a new function called something like dixLookupAnyDrawable() or something. A few other notes: It looks to me like the GLX checks go from BadMatch to BadPixmap/BadWindow - which is what the spec says, so the change is correct. It might be worthwhile doing such bug fixes separately from formatting changes though. Soren _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
