>>>>> "Peter" == Peter Hutterer <[email protected]> writes:
Peter> Signed-off-by: Peter Hutterer <[email protected]> Peter> Reviewed-by: Daniel Stone <[email protected]> Peter> --- Peter> Changes to v1: Peter> - EVIOCGID returns a struct input_id, use that instead of ushort[4]; Peter> no functional change, struct input_id is a struct of 4 ushorts anyway. Looks good. Reminds me of the discussion we had in the past about providing EVIOCGPHYS in a property (for multihead touchscreens). Peter> @@ -2340,12 +2370,14 @@ EvdevSetProperty(DeviceIntPtr dev, Atom atom, XIPropertyValuePtr val, Peter> } else if (atom == prop_swap) Peter> { Peter> if (val->format != 8 || val->type != XA_INTEGER || val->size != 1) Peter> + Peter> return BadMatch; Why the extra empty line in the middle of the conditional? -- Bye, Peter Korsgaard _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
