Using "git diff -w", Reviewed-by: Jamey Sharp <[email protected]>
Extra bonus points for the excellent commit message. Although it looks like the diff could still get a little better: On Thu, Aug 25, 2011 at 09:59:00PM -0700, Alan Coopersmith wrote: > + xf86DrvMsg(f->d.pI2CBus->scrnIndex, X_INFO, > + "MT2032: computed f_lo1=%g f_lo2=%g LO1I=%d LO2I=%d SEL=%d STEP=%d > NUM=%d\n", This parameter to xf86DrvMsg should be indented further. > + xf86DrvMsg(f->d.pI2CBus->scrnIndex, X_INFO, > + "MT2032: Company code 0x%02x%02x, part code 0x%02x, revision code > 0x%02x\n", And this one. > + xf86DrvMsg(f->d.pI2CBus->scrnIndex, X_INFO, > + "MT2032: status: XOK=%d LO1LK=%d LO2LK=%d LDONrb=%d AFC=%d TAD1=%d > TAD2=%d\n", And this one. Otherwise, the patched file looks much better. :-) Jamey
signature.asc
Description: Digital signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
