On 08/25/11 22:14, Jamey Sharp wrote:
> Using "git diff -w",
>
> Reviewed-by: Jamey Sharp <[email protected]>
>
> Extra bonus points for the excellent commit message.
>
> Although it looks like the diff could still get a little better:
>
> On Thu, Aug 25, 2011 at 09:59:00PM -0700, Alan Coopersmith wrote:
>> + xf86DrvMsg(f->d.pI2CBus->scrnIndex, X_INFO,
>> + "MT2032: computed f_lo1=%g f_lo2=%g LO1I=%d LO2I=%d SEL=%d STEP=%d
>> NUM=%d\n",
>
> This parameter to xf86DrvMsg should be indented further.
>
>> + xf86DrvMsg(f->d.pI2CBus->scrnIndex, X_INFO,
>> + "MT2032: Company code 0x%02x%02x, part code 0x%02x, revision code
>> 0x%02x\n",
>
> And this one.
>
>> + xf86DrvMsg(f->d.pI2CBus->scrnIndex, X_INFO,
>> + "MT2032: status: XOK=%d LO1LK=%d LO2LK=%d LDONrb=%d AFC=%d TAD1=%d
>> TAD2=%d\n",
>
> And this one.
I had unindented those so they didn't line wrap at 80 columns - which style
would people prefer? lines longer than 80 columns? splitting the messages
into multiple adjacent strings for the compilers to concatenate? or just
breaking the indent pattern a little as I did?
--
-Alan Coopersmith- [email protected]
Oracle Solaris Platform Engineering: X Window System
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
