On Thu, 2011-09-15 at 02:23 -0500, Jamey Sharp wrote: > On Wed, Sep 14, 2011 at 08:17:45PM -0500, Jeremy Huddleston wrote: > > This makes a difference on darwin (and apparently nowhere else) > > > > Signed-off-by: Jeremy Huddleston <[email protected]> > > --- > > According to the libtool manual, "modules that can be dlopened" need > libtool's -module switch. So I think this patch is the right thing to > do > even if it doesn't make any difference on the platforms that already > supported the xfree86 DDX. > > https://www.gnu.org/s/libtool/manual/libtool.html#Modules-for-libltdl > > Therefore: > > Reviewed-by: Jamey Sharp <[email protected]> > > But I'd also like to hear from Gaetan or somebody on this as well.
I have little hands-on experience with libraries, so I tried my google
luck. I did find posts that confirms what Jeremy is saying. On the MAC,
a module and a shared library is different. I found a post where the
converse happened. A shared library was linked to using -module and it
failed.
Yea, GnuCash's previous developers wanted gnucash to be a bunch of
Loadable
Modules.. But they never finished the modularlization, and they didn't
understand the difference between a Shared Library and a Loadable
Module.
A couple of things to verify:
* OpenBSD still uses libtool 1.5
* Solaris is different enough to get a review for this
* Ensure -module is not used for shared libraries (if makefile
flags are shared)
Reviewed-by: Gaetan Nadon <[email protected]>
>
> Jamey
signature.asc
Description: This is a digitally signed message part
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
