On 10/04/2011 09:33 AM, Keith Packard wrote:
On Tue, 4 Oct 2011 18:19:54 +0200, Michal Suchanek<[email protected]>  wrote:

Wasn't it just renamed from DestroyPixmap to ReleasePixmap?

The function was renamed, but the screen structure member was not (nor
should it have been -- it's now actually called when the pixmap is
destroyed, not just when dereferenced).

Oh, this patch sequence should *definitely* come with an ABI bump;
there's no way you can change driver source code so it can build with
either version...

With the old CreatePixmap API, drivers could override the width and height when calling down to prevent the fb layer from allocating the pixmap memory, and then plug in its own. It looks like a driver could do the same thing now by changing the pixmap structure's width and height to 0 temporarily, but it looks like that will cause the new code to call malloc(0) and then fail if it returns NULL.

-- Aaron
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to