On 2012-02-22 01:26, James Cloos wrote: > [Did I already send a review?]
No not yet. Thanks for following up on this. > > Some initial thoughts: > >> +<Multi_key> <0> <c> : "©" copyright # COPYRIGHT SIGN > > Is it really useful to use <0> (zero) for that when <O> (majuscule oh) > and <o> (miniscule oh) are already there? This allows users to enter copyright sign without using SHIFT. <c> <0> of <0> <c> would be the fastest way to enter this sign which is used regularly. This also applies to the next less often used signs. > > That also applies to § section and ¤ currency. These (©, § and ¤) originate from gtk-compose-lookaside.txt with the purpose to be merged here, upstream. They do not interfere with other schemes concerning <0> (zero). My motivation for these is to consolidate the exceptions currently defined by Simos in GTK (and GNOME) so all flavours of X will use the ones defined in Compose.pre This was also the goal of gtk-compose-lookaside.txt but that file grew over the years without merging upstream. Now it is time to start merging and hopefully get rid of it completely. > >> +<Multi_key> <exclam> <p> : "¶" paragraph # PILCROW SIGN >> +<Multi_key> <exclam> <P> : "¶" paragraph # PILCROW SIGN > > The logic of the current Multi_key sequences (<Multi_key> <exclam> is > DOT BELOW for all current sequences where it preceses a letter) would > suggest that those two would be used for the strings "p̣" and "P̣". > > Goog finds hits in wikipedia¹ (representing the IPA /pʼ/ in Riggs’ and > Williamson’s orthographies for Sioux), a usage in chemical symbols and > some hits which suggest that it may be used in latin transcriptions of > one or more of the script of India. Agreed, these two need to be removed from the patch. > > > Other wise it looks good and applies. With the caveats above, > > Reviewed-by: James Cloos <[email protected]> Thank you for the review. What are now the next steps for the patches in http://lists.x.org/archives/xorg-devel/2012-January/028253.html and http://lists.x.org/archives/xorg-devel/2012-January/028432.html Regards, Pander > > > 1] http://en.wikipedia.org/wiki/Sioux_language > http://fr.wikipedia.org/wiki/P%CC%A3 > > -JimC _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
