On 2012-02-22 17:32, Pander wrote: > On 2012-02-22 16:31, Alan Coopersmith wrote: >> On 02/22/12 03:12 AM, Pander wrote: >>> On 2012-02-22 01:26, James Cloos wrote: >>>> [Did I already send a review?] >>> >>> No not yet. Thanks for following up on this. >>> >>>> >>>> Some initial thoughts: >>>> >>>>> +<Multi_key> <0> <c> : "©" copyright # >>>>> COPYRIGHT SIGN >>>> >>>> Is it really useful to use<0> (zero) for that when<O> (majuscule oh) >>>> and<o> (miniscule oh) are already there? >>> >>> This allows users to enter copyright sign without using SHIFT.<c> <0> >>> of<0> <c> would be the fastest way to enter this sign which is used >>> regularly. This also applies to the next less often used signs. >> >> How is that any faster or less involving of the shift key than >> the current <Multi_key> <o> <c> ? >> > > Indeed not faster than that one. It is an alternative way, which is as > fast but also possible in reverse order, which the <o> <c> is not. > > The compose key sequences with <0> (zero) for §, ¤ and © originate from > gtk-compose-lookaside.txt which is being maintained by Simos Xenitellis. > > Simon, can you give additional justification for the following 12 lines: > > +<Multi_key> <0> <c> : "©" copyright # COPYRIGHT SIGN > +<Multi_key> <0> <C> : "©" copyright # COPYRIGHT SIGN > +<Multi_key> <c> <0> : "©" copyright # COPYRIGHT SIGN > +<Multi_key> <C> <0> : "©" copyright # COPYRIGHT SIGN > +<Multi_key> <s> <0> : "§" section # SECTION SIGN > +<Multi_key> <0> <s> : "§" section # SECTION SIGN > +<Multi_key> <S> <0> : "§" section # SECTION SIGN > +<Multi_key> <0> <S> : "§" section # SECTION SIGN > +<Multi_key> <0> <X> : "¤" currency # CURRENCY SIGN > +<Multi_key> <X> <0> : "¤" currency # CURRENCY SIGN > +<Multi_key> <0> <x> : "¤" currency # CURRENCY SIGN > +<Multi_key> <x> <0> : "¤" currency # CURRENCY SIGN > > Or are you willing to drop them from gtk-compose-lookaside.txt? > > Note that §, ¤ and © already have enough exiting compose key sequences > and the ones under consideration are not the most obvious sequences for > these characters. In case of dropping them from > gtk-compose-lookaside.txt they will also be dropped from my > X-GTK-consolidation patch. > > Regards, > > Pander > > PS I have made a simple Python script that used while preparing the > patch for finding inconsistencies in Compose.pre. You can find it here > http://pastebin.com/5nzQK8n4 and you will see the number of warnings and > errors drop by applying the patch.
A new patch for final review has been submitted here: https://bugs.freedesktop.org/show_bug.cgi?id=18751 The 10 lines which were labelled as not needed have been removed. The new patch has been made against git head of 2012-03-02. Please do a final review this patch and the patch: https://bugs.freedesktop.org/show_bug.cgi?id=44312 on which were no comments. Again, this will eliminate much of the differences between GTK and X11 compose key sequences which is long overdue. Please contact me if I can be of any assistance. Regards, Pander > _______________________________________________ > [email protected]: X.Org development > Archives: http://lists.x.org/archives/xorg-devel > Info: http://lists.x.org/mailman/listinfo/xorg-devel _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
