On 5/16/12 5:16 AM, Dave Airlie wrote:
@@ -340,7 +341,7 @@ vbeDoEDID(vbeInfoPtr pVbe, pointer pDDCModule)
if (!DDC_data)
return NULL;
- pMonitor = xf86InterpretEDID(pVbe->pInt10->scrnIndex, DDC_data);
+ pMonitor = xf86InterpretEDID(pVbe->pInt10->pScrn->scrnIndex,
DDC_data);
The callee here wants index->ptr conversion too, doesn't it? I don't think
I see that in subsequent patches.
That gets into an area I've been thinking about but mostly avoiding for now,
That is pretty much a logging function, i.e. scrnIndex only goes into
logging functions,
Now I'm tempted to leave logging functions just passing indices, but
I'm thinking its probably a bad idea long term, just not sure what it
is short-term.
Point taken, hadn't thought about that. You do actually want _some_
integer there, otherwise how do you distinguish two nouveau instances.
I suppose as long as the screen arrays become things that it's
physically not possible to index into then it really doesn't matter what
scrnIndex is numerically, and it'd be safe to keep using as a unique ID.
R-b for the original patch.
- ajax
_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
