Chris Wilson <[email protected]> writes:

> +extern _X_EXPORT void
> +xf86InternMode(DisplayModePtr intern, const DisplayModeRec * pMode);

The name doesn't seem very descriptive to me -- what is 'Intern'
supposed to mean?


>  /**
> + * Fills in a copy of mode, removing all stale pointer references.
> + */
> +void
> +xf86InternMode(DisplayModePtr intern, const DisplayModeRec *mode)
> +{
> +    *intern = *mode;
> +    intern->prev = intern->next = NULL;
> +    intern->name = NULL;
> +}

What should be done with ->Private? If this mode was ever actually handed
to a driver, it might not be NULL...

-- 
[email protected]

Attachment: pgpYJd3Wte3yr.pgp
Description: PGP signature

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to