Chris Wilson <[email protected]> writes: > On Wed, 30 May 2012 14:25:40 -0700, Keith Packard <[email protected]> wrote: >> Chris Wilson <[email protected]> writes: >> >> > +extern _X_EXPORT void >> > +xf86InternMode(DisplayModePtr intern, const DisplayModeRec * pMode); >> >> The name doesn't seem very descriptive to me -- what is 'Intern' >> supposed to mean? > > xf86InternalizeMode? xf86InitModeFromCopy? xf86CopyModeToStatic?
xf86SaveModeContents? (s/Contents/something-more-descriptive/?) >> What should be done with ->Private? If this mode was ever actually handed >> to a driver, it might not be NULL... > > /* And drop the backend's privates. */ > intern->PrivSize = 0; > intern->PrivFlags = 0; > intern->Private = 0; Yeah, I don't think there's anything more useful to be done here. -- [email protected]
pgpGSelz9Kkqm.pgp
Description: PGP signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
