Peter Hutterer <[email protected]> writes:

>  void
>  OsReleaseSignals(void)
>  {
>  #ifdef SIG_BLOCK
>      if (--BlockedSignalCount == 0) {
>          sigprocmask(SIG_SETMASK, &PreviousSignalMask, 0);
> +        OsReleaseSIGIO();
>      }
>  #endif

Should you use SIG_UNBLOCK instead of SIG_SETMASK? It took me several
minutes to figure out that SIG_SETMASK will work because
PreviousSignalMask *always* contains SIGIO as it is set after
the call to OsBlockSIGIO in OsBlockSignals. Either that, or a comment
explaining why this works so future-me doesn't get confused again...

-- 
[email protected]

Attachment: pgpy54Y9H0LrV.pgp
Description: PGP signature

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to