On 07/ 9/12 06:02 PM, Daniel Stone wrote: > If failing to disable a protocol specified by -nolisten failed, we'd > throw a FatalError and bomb startup entirely. From poking at xtrans, it > looks like the only way we can get a failure here is because we've > specified a protocol name which doesn't exist, which probably doesn't > constitute a security risk. > > And it makes it possible to start gdm even though you've built with > --disable-tcp-transport. > > Signed-off-by: Daniel Stone <[email protected]> > --- > os/utils.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/os/utils.c b/os/utils.c > index 2537934..b00d38b 100644 > --- a/os/utils.c > +++ b/os/utils.c > @@ -757,8 +757,8 @@ ProcessCommandLine(int argc, char *argv[]) > else if (strcmp(argv[i], "-nolisten") == 0) { > if (++i < argc) { > if (_XSERVTransNoListen(argv[i])) > - FatalError("Failed to disable listen for %s transport", > - argv[i]); > + ErrorF("Failed to disable listen for %s transport", > + argv[i]); > } > else > UseMsg();
Reviewed-by: Alan Coopersmith <[email protected]> -- -Alan Coopersmith- [email protected] Oracle Solaris Engineering - http://blogs.oracle.com/alanc _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
