Hi Matt, Thank you for your review. We really appreciate that you've pick out so many issues we need to improve. It seems that we still have a lot of work to do to match the quality which can be accepted by X.Org. We will fix the issue you've reported before next submission. One more question: How many patches shall I make instead of one big patch?
Aaron -----邮件原件----- 发件人: Matt Turner [mailto:[email protected]] 发送时间: 2012年7月12日 0:32 收件人: Aaron.Chen 陈俊杰 抄送: [email protected]; caesar.qiu 裘赛海 主题: Re: [PATCH]new driver for siliconmotion On Tue, Jul 10, 2012 at 8:24 PM, Matt Turner <[email protected]> wrote: > 64 Megabytes in bytes is too large for a signed int. This code cannot > work. It's clear that someone thought about this, since there's a > more-correct commented-out function signature above it. Math fail. Ignore this hunk. The commented-out signature should be removed though. _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
