Robert Morell <[email protected]> writes:

> Numbers beginning with '-' were falling into the DASH category.

Yeah, but you're breaking the parsing of sync intervals which use NUMBER
DASH NUMBER. You can fix this in two ways -- use your current hack to
glue the '-' to the following number and then go fix the sync interval
parsing to handle negative numbers, or fix the places where a negative
number is valid to handle DASH NUMBER as well as just NUMBER.

Can you briefly enumerate where negative numbers are valid in the config file?

> This also caused a confusing error message, since no terminating NUL
> character was added to configRBuf -- old garbage in the string would be
> printed.  This fixes the terminating NUL for COMMA as well.

Nice fix there.

-- 
[email protected]

Attachment: pgpgGfSLBxWcw.pgp
Description: PGP signature

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to