On 07/31/13 09:12 AM, Ross Burton wrote:
Automatically enabling or disabling a feature based on installed files isn't
deterministic, and AC_CHECK_FILE returns an error when cross-compiling.

Fix this by enabling DRI by default, and removing the explicit file checks as
pkg-config is good enough.

(#57606)

Signed-off-by: Ross Burton <[email protected]>
---
  configure.ac |   25 ++-----------------------
  1 file changed, 2 insertions(+), 23 deletions(-)

What is this patch against?   I don't see those AC_CHECK_FILE calls in
the xserver git repo, nor in xf86-video-intel.   Doing a grep across all
the git clones I have suggests it could be xf86-video-mach64, -mga, -qxl,
-r128, -savage, -sis, -tdfx, -xgi or -xgixp.

As for the patch itself, why not use PKG_CHECK_EXISTS to set the default if
the required modules ([libdrm >= 2.0 xf86driproto]) are present?

--
        -Alan Coopersmith-              [email protected]
         Oracle Solaris Engineering - http://blogs.oracle.com/alanc
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to