On 07.11.2013 04:45, Keith Packard wrote: > I've generated a new sequence of patches in response to the very > helpful review comments received so far. Thanks to all involved! > > Some simple cleanups that I have found useful. Patch 3/8 has been > split out from the event queue patch and matches a change made to the > XCB proto that adds an XML description of the X generic event > structure. Seems like a sensible plan to me, given that the protocol > generator already knows about the XGE fields > > [PATCH 1/8] Make protocol C files depend on protocol XML files > [PATCH 2/8] -pendantic is too pendantic > [PATCH 3/8] Remove xcb_ge_event_t from xcb.h
Oh, this means we also need a new xcb-proto release. That should have been clear to anyone thinking about all of this for 0.5 seconds, but I totally missed that. This means we need to bump our minimum required version of xcb-proto in libxcb. Is there anything in xcb-proto's git master which isn't ready releasable? > Deal with fd passing. This is now enabled only on Linux as the recvmsg > code does not support non-Linux systems using the CMSG APIs. A > configure.ac variable is also made available to disable extensions > which require FD passing (like DRI3). > > [PATCH 4/8] Add xcb_send_fd API > [PATCH 5/8] Add support for receiving fds in replies > > Here's the event queue splitting API. The polling function is now > called xcb_poll_for_special_event, and the XGE filtering creator is > now called xcb_register_for_special_xge. > > [PATCH 6/8] Add event queue splitting > > DRI3 is now enabled only when sendmsg is usable for FD passing > (Linux-only, until the sendmsg/recvmsg bits are fixed for non-Linux systems). > > [PATCH 7/8] Add DRI3 library > [PATCH 8/8] Add Present extension All the patches except for patch 4 (with my comments included and tabs removed): Reviewed-By: Uli Schlachter <[email protected]> Uli -- "In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move." _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
